Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GUI Translation demo for 4.0 #930

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Update GUI Translation demo for 4.0 #930

merged 2 commits into from
Apr 12, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 7, 2023 •
edited
Loading

  • Add PO support in addition to CSV.

Note that this PR does not include support for CSV plurals, as that feature isn't merged in Godot yet.

@Calinou @SkyLucilfer
Update GUI Translation demo for 4.0
0c48c79 
- Add PO support in addition to CSV.

Co-authored-by: SkyJJ <[email protected]>
@Calinou Calinou mentioned this pull request Sep 15, 2023
Open
89 tasks
@Calinou Calinou mentioned this pull request Oct 18, 2023
Closed
@Alex2782
Copy link
Contributor

Alex2782 commented Oct 19, 2023 •
edited
Loading

#974 (review)

Also, do we need to ship all the font with the demos? For the Mirroring and Translation demos system font fallback should be fine, neither require specific font dimensions to work.

I wanted to check if the 'fonts' can be removed here too, but it already says in the description that they are necessary on some systems.

@Calinou this PR works for you? And master branch not? #974 (review)

  • Label HELLO_TEXT has here normal 'droid_sans.tres' font
  • Label HELLO_TEXT has in master no font (empty) and this errors (but I have no problems with the Japanese font.)
  Class 'Font' or its base class cannot be instantiated.
  editor/plugins/editor_preview_plugins.cpp:803 - Condition "sampled_font.is_null()" is true. Returning: Ref<Texture2D>()

this PR
image

aaronfranke
aaronfranke approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aaronfranke aaronfranke merged commit 5bda007 into godotengine:master Apr 12, 2024
1 check passed
@Calinou Calinou deleted the update-translation-demo branch April 15, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
enhancement update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @Alex2782 @aaronfranke